Skip to content

Adding getTotalColdkeyStakeand getTotalHotkeyStake to the staking precompile #1159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Feb 25, 2025
Merged

Adding getTotalColdkeyStakeand getTotalHotkeyStake to the staking precompile #1159

merged 13 commits into from
Feb 25, 2025
+106 −7

Conversation

Shr1ftyy
Copy link
Contributor

@Shr1ftyy Shr1ftyy commented Jan 15, 2025 •
edited
Loading

Description

Adds a getTotalColdkeyStake and getTotalHotkeyStake to the staking precompile

Related Issue(s)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Shr1ftyy Shr1ftyy marked this pull request as ready for review January 20, 2025 06:00
@Shr1ftyy Shr1ftyy requested a review from unconst as a code owner January 20, 2025 06:00
@Shr1ftyy Shr1ftyy changed the title Adding a getStakeColdkey method to the staking precompile Adding a getTotalColdkeyStake, and getTotalHotkeyStake method to the staking precompile Jan 21, 2025
@Shr1ftyy Shr1ftyy changed the title Adding a getTotalColdkeyStake, and getTotalHotkeyStake method to the staking precompile Adding getTotalColdkeyStakeand getTotalHotkeyStake to the staking precompile Jan 21, 2025
@gztensor gztensor added the skip-cargo-audit This PR fails cargo audit but needs to be merged anyway label Jan 21, 2025
@Shr1ftyy
feat: modify total stake coldkey func
3de9c3d 
- gets stake for coldkey on subnet and across all subnets
open-junius
open-junius reviewed Jan 27, 2025
View reviewed changes
@sam0x17 sam0x17 requested a review from open-junius February 24, 2025 20:02
@sam0x17
Copy link
Contributor

sam0x17 commented Feb 24, 2025

let's re-review this and see if we can get it merged if it looks good @open-junius 🙏🏻

open-junius
open-junius previously approved these changes Feb 25, 2025
View reviewed changes
@open-junius
Copy link
Contributor

opentensor/subtensor-js-tests#10 used to verify the PR e2e. test passed.

@open-junius open-junius requested a review from ales-otf February 25, 2025 15:22
@sam0x17 sam0x17 merged commit 7c329f9 into opentensor:devnet-ready Feb 25, 2025
17 checks passed
This was referenced Feb 27, 2025
Closed
Closed
@sam0x17 sam0x17 mentioned this pull request Mar 6, 2025
Merged
@Shr1ftyy Shr1ftyy mentioned this pull request Mar 8, 2025
Closed
13 tasks
This was referenced Mar 11, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sam0x17 sam0x17 sam0x17 approved these changes

@open-junius open-junius open-junius approved these changes

@unconst unconst Awaiting requested review from unconst

@gztensor gztensor Awaiting requested review from gztensor

@ales-otf ales-otf Awaiting requested review from ales-otf

Assignees
No one assigned
Labels
skip-cargo-audit This PR fails cargo audit but needs to be merged anyway
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Shr1ftyy @sam0x17 @open-junius @gztensor